add webpack bundle injection and unit tests to build-plugins #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set skipLibCheck on tsconfig to unblock progress in short-term (unplugin .d.ts file causes issues due to compile-time dependencies on other plugins)
t2t2
approved these changes
Oct 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the unplugin library, which should help us support other build tools in future. The "hooks" that
unplugin supports right now does not appear to help with injection into resulting bundles. So a custom webpack
config was added to help with this.
Adding skipTestLib to unblock work in short-term. Will need to figure out how to deal with unplugin transitive
dev/peer dependencies which are causing compile issues in its .d.ts file.
Type of change
How has this been tested?
Future task will handle integration test
Local manual tests performed using a Cisco repo with a Next.js 14 app